Hi Kalle,
On 2/4/2019 7:08 PM, Kalle Valo wrote:
> <Ajay.Kathat@xxxxxxxxxxxxx> writes:
>
>> From: Ajay Singh <ajay.kathat@xxxxxxxxxxxxx>
>>
>> Avoid use of static variable for monitor net_device and move it inside
>> wilc structure.
>>
>> Signed-off-by: Ajay Singh <ajay.kathat@xxxxxxxxxxxxx>
>
> [...]
>
>> --- a/drivers/staging/wilc1000/linux_mon.c
>> +++ b/drivers/staging/wilc1000/linux_mon.c
>> @@ -18,8 +18,6 @@ struct wilc_wfi_radiotap_cb_hdr {
>> u16 tx_flags;
>> } __packed;
>>
>> -static struct net_device *wilc_wfi_mon; /* global monitor netdev */
>> -
>> static u8 srcadd[6];
>> static u8 bssid[6];
>
> I hope you are working on moving srcadd and bssid as well (at some
> point).
>
Yes, I will take care of this before submitting the driver for another
mainline review.
Regards,
Ajay
