Brian Norris <briannorris@xxxxxxxxxxxx> wrote: > This reverts commit cfb353c0dc058bc1619cc226d3cbbda1f360bdd3. > > WCN3990 firmware does not yet implement this feature, and so it crashes > like this: > > fatal error received: err_qdi.c:456:EX:wlan_process:1:WLAN RT:207a:PC=b001b4f0 > > This feature can be re-implemented with a proper service bitmap or other > feature-discovery mechanism in the future. But it should not break > working boards. > > Fixes: cfb353c0dc05 ("ath10k: add quiet mode support for QCA6174/QCA9377") > Cc: Yu Wang <yyuwang@xxxxxxxxxxxxxx> > Cc: Rakesh Pillai <pillair@xxxxxxxxxxxxxx> > Cc: Govind Singh <govinds@xxxxxxxxxxxxxx> > Cc: <stable@xxxxxxxxxxxxxxx> > Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx> This regression should be fixed by (which is in v4.20): 53884577fbce ath10k: skip sending quiet mode cmd for WCN3990 So this revert should not be needed anymore and I'll drop this. -- https://patchwork.kernel.org/patch/10672903/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches