Hi Greg, On 2/4/2019 5:09 PM, Greg KH wrote: > On Mon, Feb 04, 2019 at 12:47:23PM +0300, Dan Carpenter wrote: >> On Mon, Feb 04, 2019 at 09:42:36AM +0000, Ajay.Kathat@xxxxxxxxxxxxx wrote: >>> >>> >>> On 2/4/2019 1:43 PM, Dan Carpenter wrote: >>>> On Sat, Feb 02, 2019 at 07:17:13PM +0000, Ajay.Kathat@xxxxxxxxxxxxx wrote: >>>>> From: Ajay Singh <ajay.kathat@xxxxxxxxxxxxx> >>>>> >>>>> The value of 'vif_num'(interface count) starts with 0, so modified the >>>>> loop conditions to execute for all interface. >>>>> >>>>> Signed-off-by: Ajay Singh <ajay.kathat@xxxxxxxxxxxxx> >>>> >>>> The right thing to do is to change ->vif_num = i + 1 in >>>> wilc_netdev_init(). That's how it was originally. Please, add a >>>> Fixes tag. >>>> >>>> Fixes: 735bb39ca3be ("staging: wilc1000: simplify vif[i]->ndev accesses") >>>> >>> >>> Thanks. Sure, I will add Fixes tag and resubmit the changes. >>> >>> Can other patches from the series be applied excluding this or should I >>> resubmit the complete series? >>> Please suggest. >> >> I don't have an opinion on that. I guess if you just resend them all, >> that's the easiest for Greg. > > I took the first 7 patches here, so just a respin of the remaining ones > would be fine. > Thanks alot. This patch will take some time for modification. As remaining patches are not dependent on this. I will resend them. Regards, Ajay