Search Linux Wireless

Re: [PATCH v3 00/13] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tony Chuang <yhchuang@xxxxxxxxxxx> writes:

>> I suggest to look at criticality of the bug and size of the patch. For
>> example, if the bug is a minor and the patch is large you should
>> definitely drop that. And smaller fixes to severe bugs you should
>> definitely again include them.
>> 
>> Just remember to list in the changelog every change you made since
>> previous version.
>> 
>
> Hi Kalle,
>
> One more question, should I merge the trivial patches into the original
> patch set and resend them like [PATCH v4 00/13].
>
> Or should I add them after the 13 patches for people to review easily.
> Such as [PATCH v4 00/21]. Which do you prefer?

I don't have any strong opinion but I prefer the former (13 patches).
Others might think differently.

BTW, I don't if you are aware but I will add the driver to
wireless-drivers-next in commit, so in the end we need to squash these
patches into patch. Only in review it's easier to have them split like
this. But we don't need to worry about that right now, let's focus on
people reviewing the driver first.

-- 
Kalle Valo



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux