> -----Original Message----- > From: Brian Norris [mailto:briannorris@xxxxxxxxxxxx] > Sent: Tuesday, January 29, 2019 10:41 AM > To: Tony Chuang > Cc: Larry Finger; Pkshih; Andy Huang; sgruszka@xxxxxxxxxx; > linux-wireless@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v3 00/13] rtw88: mac80211 driver for Realtek 802.11ac > wireless network chips > > On Mon, Jan 28, 2019 at 6:15 PM Tony Chuang <yhchuang@xxxxxxxxxxx> > wrote: > > This NULL pointer was found months ago and has been fixed already. > > Thanks for your test :). > > I am holding the patch to fix it for the next patchsets. > > > > BTW, since rtw88 has not been accepted, could I send next patch set based on > > this patch set as long as I explicitly mark that the next patch is based on the > previous one? > > I'd normally expect that if you find major bugs in your initial driver > submission that still isn't reviewed/merged, you might as well just > roll the fix into latest version and describe it in the > cover-letter/changelog. This particular change is so trivial it > doesn't really seem to deserve a separate patch. > > (It would also help people like me, who may very well run into the > same bug when they get around to testing/reviewing the driver.) > > I also don't know what the contents of the "next patch set" is -- if > it's a lot of new features, maybe they don't deserve to clutter the > initial submission, but if they're bugfixes like this, it seems like > you could just fix the original patch set. It is because that the next patch set contains several major fixes. And I don't know if it will bother the reviewers if I apply them into the original patch set. And I don't know if I can send the next patch set that is based on the patch set have not been accepted. Just wonder which way is better. So, if it is how things work I can do this and resend with those fixes. It is actually better for me to fix them in the original patch set. Or send the next patch set now and mark it is based on the original patch set under reviewing. > > But that's just my opinion. Your opinion is helpful. Thanks for your suggestion. > > Brian > Yan-Hsuan
