On Thu, Jan 24, 2019 at 11:50:49PM +0100, Lorenzo Bianconi wrote:
> > if (changed & BSS_CHANGED_BEACON_ENABLED) {
> > - tasklet_disable(&dev->pre_tbtt_tasklet);
> > + skb = NULL;
> > + if (info->enable_beacon && mt76_is_usb(dev))
> > + skb = ieee80211_beacon_get(hw, vif);
>
> What about moving this in mt76x02_mac_set_beacon_enable(), I guess the code
> will be more readable. Moreover you can move skb pointer declaration in
> if (changed & BSS_CHANGED_BEACON_ENABLED) block
Ok, make sense.
Regarding your other remarks, I do not see utility to address them.
Thanks
Stanislaw
