On Thu, 2019-01-17 at 16:54 +0530, Balaji Pothunoori wrote: > > + * @txpwr: indicates the tx power, in mBm, to be used when sending data frames > + * to the STA. > + * @type: In particular if TPC %type is NL80211_TX_POWER_LIMITED then txpwr will > + * be less than or equal to specified from userspace, whereas if TPC %type > + * is NL80211_TX_POWER_AUTOMATIC then it indicates default txpwr. > + * NL80211_TX_POWER_FIXED is not a valid configuration option for > + * per peer TPC. Same comment here wrt. txpower_type or so. > +TRACE_EVENT(drv_sta_set_txpwr, > + TP_PROTO(struct ieee80211_local *local, > + struct ieee80211_sub_if_data *sdata, > + struct ieee80211_sta *sta), > + > + TP_ARGS(local, sdata, sta), > + > + TP_STRUCT__entry( > + LOCAL_ENTRY > + VIF_ENTRY > + STA_ENTRY > + __field(s16, txpwr) > + ), > + > + TP_fast_assign( > + LOCAL_ASSIGN; > + VIF_ASSIGN; > + STA_ASSIGN; > + __entry->txpwr = sta->txpwr; > + ), Include the type as well? OTOH, is this whole business with the type even needed everywhere? johannes