Search Linux Wireless

Re: [PATCH 1/2] mt76: fix per-chain signal strength reporting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 22, 2019 at 04:38:22PM +0100, Felix Fietkau wrote:
> Fix an off-by-one error that resulted in not reporting the signal strength
> for the first chain
> 
> Signed-off-by: Felix Fietkau <nbd@xxxxxxxx>

Not sure how serious this bug is, but I think patch should be marked:

Fixes: d9f8934ed147 ("mt76: move mt76x02_mac_process_rx in mt76x02-lib module")
Cc: stable@xxxxxxxxxxxxxxx # 4.20+

Thanks
Stanislaw

> ---
>  drivers/net/wireless/mediatek/mt76/mt76x02_mac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c b/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c
> index ce9bb702045f..63fa27d2c404 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt76x02_mac.c
> @@ -648,7 +648,7 @@ int mt76x02_mac_process_rx(struct mt76x02_dev *dev, struct sk_buff *skb,
>  
>  	status->chains = BIT(0);
>  	signal = mt76x02_mac_get_rssi(dev, rxwi->rssi[0], 0);
> -	for (i = 1; i < nstreams; i++) {
> +	for (i = 0; i < nstreams; i++) {
>  		status->chains |= BIT(i);
>  		status->chain_signal[i] = mt76x02_mac_get_rssi(dev,
>  							       rxwi->rssi[i],
> -- 
> 2.17.0
> 



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux