(+John) On 01/07/2019 9:05, Hans de Goede wrote: > Hi, > > On 07-01-19 12:58, Arend Van Spriel wrote: >> On 1/7/2019 12:34 PM, Hans de Goede wrote: > > Cypress is actually doing both the old (embedded info) and the new > (separate clm_blob) model for the firmwares which they are now maintaining, > they are still providing updates *with the embedded info, see e.g.: > https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/brcm?id=253a573936ee2078d206527f3ae845b4dc681269 Hi Hans, 43362 is a very old chip that it doesn't support the clm_blob model. For newer chips (some in newer builds) we use clm_blob by default. The clm_blob should be an optional file and the desired behavior is to fall through even when the file is not there. As Kalle and Arend mentioned, using request_firmware_nowarn() is more appropriate. Thanks for posting this enhancement. > Cypress does the null-table + separate clm_blob file thing and for reasons > which they have never explained they insist on the linux-firmware files and > their own files being different. The binary files in linux-firmware are taken from the release packages. The latest binary with embedded clm (historical mode) were upstreamed. Will explain more about the clm_blobs in the V2 comment. > A "Firmware crash fix" to me sounds like a potential security issue, yet It is a functional bug that causes wifi to stop working correctly. Not a security hole. We did upstream firmware for security issues. > Another example is the firmware for the wifi on the Raspberry Pi 3B+ which > is *years* older in linux-firmware. Could you please specify the source (link) of the firmware you're referring to? > > I must say these whole shenanigans with the firmware causing > linux-firmware to > have way too old firmware versions makes me very unhappy. I'm at the point > where I'm telling friends to not buy any hardware with Cypress wifi in > there > because of this and because of the *complete* lack of bluetooth firmware. We did work with HTC to upstream their bluetooth firmware to linux-firmware, although I admit that most of the bluetooth firmware are only available through hardware vendors. Bluetooth firmware files are specific to vendor board designs. When there is an update, the hardware (device/board) vendor qualifies the firmware and release through their preferred channel (in HTC's case they chose to upstream it). Regards, Chi-hsien Lin
