On 01/03/2019 5:56, James Hughes wrote: > On Thu, 3 Jan 2019 at 07:46, Chi-Hsien Lin <Chi-Hsien.Lin@xxxxxxxxxxx> wrote: >> >> From: Lo-Hsiang Lo <double.lo@xxxxxxxxxxx> >> >> There is a system warning message, warn_slowpath-fmt, during suspend >> while using supplicant join AP and enable wowl feature by IW command. >> It's cuased by brcmf_pno_remove_request path can't find the reqid. >> This fix will not go to remove pno request function if there is no >> pno scan. > > Typo in the commit message `cuased` James, Thanks for catching this. I've submitted V2 to fix both typos. > >> >> Signed-off-by: Lo-Hsiang Lo <double.lo@xxxxxxxxxxx> >> Signed-off-by: Chi-Hsien Lin <chi-hsien.lin@xxxxxxxxxxx> >> --- >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c >> index ffa243e2e2d0..55974a43796a 100644 >> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c >> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c >> @@ -496,6 +496,11 @@ int brcmf_pno_stop_sched_scan(struct brcmf_if *ifp, u64 reqid) >> brcmf_dbg(TRACE, "reqid=%llu\n", reqid); >> >> pi = ifp_to_pno(ifp); >> + >> + /* No PNO reqeuset */ > > Typo. `reqeuset` > >> + if (!pi->n_reqs) >> + return 0; >> + >> err = brcmf_pno_remove_request(pi, reqid); >> if (err) >> return err; >> -- >> 2.1.0 >>