> On Dec 20, 2018, at 14:42, Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote: > > Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx> wrote: > >> Once BSS STA mode gets started, it can be scanned by other clients but >> cannot entablish a connection. >> >> Turns out the set_bcn_reg() and its *_set_beacon_related_registers() >> callbacks never get called so it has problem beaconing. >> >> Enable the function in rtl_op_bss_info_changed() can make BSS STA mode >> start to work. >> >> Signed-off-by: Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx> > > The commit log is quite misleading. It implies that the client mode is broken > for all rtlwifi hardware and that can't be the case, otherwise we would be > flooded by bug reports. So please improve the commit log and describe clearly > the problem you are solving. You are right. I'll wait for PKShih’s test result and update commit log afterwards. Kai-Heng > > -- > https://patchwork.kernel.org/patch/10725537/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches >
