On 2018-12-18 19:10, Otcheretianski, Andrei wrote:
So, interesting - Andrei also added the PMKID but also the PMK here,
in a
separate patch:
https://patchwork.kernel.org/patch/10732093/
Yeah, PMK is needed for the devices that offload 4way handshake.
Thanks. Fine with us too. Will have an updated patchset with the pmkid
part removed, as this is already added with the patch by Andrei.
[...]
> - if (!info->attrs[NL80211_ATTR_SSID])
> + if (!info->attrs[NL80211_ATTR_SSID] &&
> + dev->ieee80211_ptr->iftype != NL80211_IFTYPE_AP &&
> + dev->ieee80211_ptr->iftype != NL80211_IFTYPE_AP_VLAN &&
> + dev->ieee80211_ptr->iftype != NL80211_IFTYPE_P2P_GO)
> return -EINVAL;
Hm. do we really expect this on AP_VLAN?
Actually I'm not sure about GO neither. P2P doesn't use SAE etc..
Andrei
Since these vifs are similar to an AP, we have considered external
authentication to be applicable for them as well. Please let me know if
this is fine . I shall update the patch accordingly.
johannes
Thanks,
Srinivas
