From: Shahar S Matityahu <shahar.s.matityahu@xxxxxxxxx> Add a break at the end of the ini tlv case. Fix both the internal and external tlv parsing. type=bugfix ticket=none fixes=I76eba109fa3d0ff5cbda3da850ff7c2c5f895cce fixes=Ibd8d7bc971d83f6aed5b73118ebdc6243a636a4e Change-Id: Ic4f681055bad81e72acafa12f81d5ba3f1afeb11 Signed-off-by: Shahar S Matityahu <shahar.s.matityahu@xxxxxxxxx> Reviewed-on: https://git-amr-3.devtools.intel.com/gerrit/199704 automatic-review: ec ger unix iil jenkins <EC.GER.UNIX.IIL.JENKINS@xxxxxxxxx> Tested-by: ec ger unix iil jenkins <EC.GER.UNIX.IIL.JENKINS@xxxxxxxxx> Reviewed-by: Coelho, Luciano <luciano.coelho@xxxxxxxxx> --- drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c | 1 + drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c index bc1e4d4bb42d..43d815cb3ce9 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c +++ b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c @@ -201,6 +201,7 @@ static int iwl_parse_fw_dbg_tlv(struct iwl_trans *trans, const u8 *data, case IWL_UCODE_TLV_TYPE_TRIGGERS: case IWL_UCODE_TLV_TYPE_DEBUG_FLOW: iwl_fw_dbg_copy_tlv(trans, tlv, true); + break; default: WARN_ONCE(1, "Invalid TLV %x\n", tlv_type); break; diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c index a65ba955783d..bf1be985f36b 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c +++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c @@ -1097,6 +1097,7 @@ static int iwl_parse_tlv_firmware(struct iwl_drv *drv, case IWL_UCODE_TLV_TYPE_DEBUG_FLOW: if (iwlwifi_mod_params.enable_ini) iwl_fw_dbg_copy_tlv(drv->trans, tlv, false); + break; default: IWL_DEBUG_INFO(drv, "unknown TLV: %d\n", tlv_type); break; -- 2.14.4
