Hi all, On Fri, 30 Nov 2018 12:05:55 +1100 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote: > > After merging the wireless-drivers-next tree, today's linux-next build > (x86_64 allmodconfig) produced these warnings: > > drivers/net/wireless/intel/iwlwifi/iwl-drv.c: In function 'iwl_parse_tlv_firmware': > drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1098:7: warning: this statement may fall through [-Wimplicit-fallthrough=] > if (iwlwifi_mod_params.enable_ini) > ^ > drivers/net/wireless/intel/iwlwifi/iwl-drv.c:1100:3: note: here > default: > ^~~~~~~ > drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c: In function 'iwl_parse_fw_dbg_tlv': > drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:203:4: warning: this statement may fall through [-Wimplicit-fallthrough=] > iwl_fw_dbg_copy_tlv(trans, tlv, true); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c:204:3: note: here > default: > ^~~~~~~ > > Introduced by commit > > f14cda6f3b31 ("iwlwifi: trans: parse and store debug ini TLVs") > > These are noted because I use -Wimplict-fallthrough > > The warnings can be suppressed by adding a comment like > /* fall through */ > at the appropriate place to indicate that the fallthough is intended. I am still seeing these warnings (but in the net-next tree now) and I do not see a fix patch in the wireless-drivers-next tree. -- Cheers, Stephen Rothwell
Attachment:
pgpGc60RrXzLs.pgp
Description: OpenPGP digital signature