On Thu, 2018-11-29 at 12:01 +0200, Kalle Valo wrote: > Luca Coelho <luca@xxxxxxxxx> writes: > > > From: Luca Coelho <luciano.coelho@xxxxxxxxx> > > > > Using OTP_LOW_IMAGE_SIZE_FAMILY_8000/9000/22000 only obfuscates the > > actual values, since these 3 are the same. Redefine the values per > > size so it's easier to understand and compare the different > > configurations. > > > > Signed-off-by: Luca Coelho <luciano.coelho@xxxxxxxxx> > > [...] > > > --- a/drivers/net/wireless/intel/iwlwifi/cfg/1000.c > > +++ b/drivers/net/wireless/intel/iwlwifi/cfg/1000.c > > @@ -48,7 +48,7 @@ > > static const struct iwl_base_params iwl1000_base_params = { > > .num_of_queues = IWLAGN_NUM_QUEUES, > > .max_tfd_queue_size = 256, > > - .eeprom_size = OTP_LOW_IMAGE_SIZE, > > + /* .eeprom_size = OTP_LOW_IMAGE_SIZE_2K, */ > > Why this is commented out? Nice catch! I have no idea what happened here, this was never commented out in our internal tree... I'll send v2. -- Luca.