Search Linux Wireless

Re: [PATCH] mt76: handle protocol error to proper deinit rx_tasklet

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > > > During removal of usb dongle, noticed many unhandled rx urb
> > > > below. This this patch, make it possible and early completion
> > > > of the rx tasklet.

[...]

> > > Hi Eduardo,
> > >
> > > I think EPROTO is a more general error (it is not strictly related to
> > > device removal)
> > > and it could happen even during normal operation. In this case I guess we should
> > > reinsert the urb to usb-core.
> >
> > Some (out of tree) usb host drivers returns EPROTO all the time
> > in some error conditions. On rt2x00 resubmitting urb resulted in
> > infinity loop:
> > https://marc.info/?t=153375128700002&r=1&w=2
> >
> > Fix I proposed for that was counting EPROTO errors and
> > mark device as removed if 10 of them happened in row:
> > https://marc.info/?l=linux-wireless&m=153441755529960&w=2
>
> Thanks for the feedback, guys.
>
> Would it be ok for you if I respin the patch with the suggested
> approach by Stanislaw?

Hi Eduardo,

AFAIU the -EPROTO error is reported only during device removal or just
sporadically
(you have never experienced any infinity loop). Is it correct?
If so I guess we do not need to develop any intrusive workaround since
it is just an annoying log message

Regards,
Lorenzo

>
> Regards,
> Eduardo
> >
> > Thanks
> > Stanislaw



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux