On 2018-11-13 20:41, Felix Fietkau wrote: > If there are still pending packets in the tx queue when removing a station, > it could possibly lead to a call to further attempts to pull packets from > the mac80211 tx queue after it has already been removed from the scheduling > list. > Prevent this from happening by calling synchronize_rcu after deleting the > wcid pointer before further cleaning up the tx queues. > To be extra careful, ensure that mtxq->list is always initialized properly. > > Also drop the useless call to mt76x02_mac_wcid_setup, which only re-assigns > the bss index of the wcid entry, but does not help with the cleanup in any > way. I misread the code and the call to mt76x02_mac_wcid_setup matters after all. Will send a v2 of this series with further improvements. - Felix
