Search Linux Wireless

Re: [PATCH] brcmfmac: Use standard SKB list accessors in brcmf_sdiod_sglist_rw.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/14/2018 11:57 AM, Arend van Spriel wrote:
On 11/14/2018 11:54 AM, Andy Duan wrote:
From: Arend van Spriel [mailto:arend.vanspriel@xxxxxxxxxxxx] Sent:
2018年11月14日 16:40
To: Andy Duan <fugang.duan@xxxxxxx>; David Miller
<davem@xxxxxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx
Cc: linux-wireless@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] brcmfmac: Use standard SKB list accessors in
brcmf_sdiod_sglist_rw.

On 11/14/2018 4:28 AM, Andy Duan wrote:
From: David Miller <davem@xxxxxxxxxxxxx> Sent: 2018年11月11日 8:34
[ As I am trying to remove direct SKB list pointer accesses I am
  committing this to net-next.  If this causes a lot of grief I
  can and will revert, just let me know. ]

[...]


I just have bcm4339 in hands, test the patch on i.MX7D sdb board with
bcm4339, it works fine with iperf testing.

Tested-by: Fugang Duan <fugang.duan@xxxxxxx>

Thanks, Andy

Can you do one more check? Please insert brcmfmac with module parameter
debug=2 and let me know if the following log message is seen:

brcmfmac: brcmf_sdiod_sgtable_alloc: nents=X

If not seen, the driver does not go through the patched code.
My kernel don't enable debug and DEBUG and CONFIG_BRCM_TRACING, I add
the debug info in the brcmf_sdiod_sgtable_alloc(), and the log show
the driver go through the sg path:
Log: brcmf_sdiod_sgtable_alloc: max_segs:128, sg_support:1, nents=35

Thanks, Andy

Works for me ;-)

I should better read the patch email. I tried to apply the patch to wireless-testing, but it failed simply because the patch is already in place through net-next as Dave mentioned. Anyway, it is good that it has been tested to some extent.

Regards,
Arend




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux