Search Linux Wireless

Re: [PATCH v2 6/6] ath10k: reporting estimated tx airtime for fairness

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Kan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on mac80211/master]
[also build test WARNING on v4.20-rc1]
[cannot apply to next-20181112]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Rajkumar-Manoharan/Move-TXQ-scheduling-and-airtime-fairness-into-mac80211/20181111-072032
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git master
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   include/linux/slab.h:332:43: warning: dubious: x & !y
   include/linux/slab.h:332:43: warning: dubious: x & !y
>> net/mac80211/tx.c:3751:6: warning: context imbalance in 'ieee80211_txq_schedule_start' - wrong count at exit
>> net/mac80211/tx.c:3760:6: warning: context imbalance in 'ieee80211_txq_schedule_end' - unexpected unlock

vim +/ieee80211_txq_schedule_start +3751 net/mac80211/tx.c

30e0c998 Toke Høiland-Jørgensen 2018-11-09  3750  
713c0ba8 Toke Høiland-Jørgensen 2018-11-09 @3751  void ieee80211_txq_schedule_start(struct ieee80211_hw *hw, u8 ac)
713c0ba8 Toke Høiland-Jørgensen 2018-11-09  3752  {
713c0ba8 Toke Høiland-Jørgensen 2018-11-09  3753  	struct ieee80211_local *local = hw_to_local(hw);
713c0ba8 Toke Høiland-Jørgensen 2018-11-09  3754  
713c0ba8 Toke Høiland-Jørgensen 2018-11-09  3755  	spin_lock_bh(&local->active_txq_lock[ac]);
713c0ba8 Toke Høiland-Jørgensen 2018-11-09  3756  	local->schedule_round[ac]++;
713c0ba8 Toke Høiland-Jørgensen 2018-11-09  3757  }
713c0ba8 Toke Høiland-Jørgensen 2018-11-09  3758  EXPORT_SYMBOL(ieee80211_txq_schedule_start);
713c0ba8 Toke Høiland-Jørgensen 2018-11-09  3759  
713c0ba8 Toke Høiland-Jørgensen 2018-11-09 @3760  void ieee80211_txq_schedule_end(struct ieee80211_hw *hw, u8 ac)
713c0ba8 Toke Høiland-Jørgensen 2018-11-09  3761  {
713c0ba8 Toke Høiland-Jørgensen 2018-11-09  3762  	struct ieee80211_local *local = hw_to_local(hw);
713c0ba8 Toke Høiland-Jørgensen 2018-11-09  3763  
713c0ba8 Toke Høiland-Jørgensen 2018-11-09  3764  	spin_unlock_bh(&local->active_txq_lock[ac]);
713c0ba8 Toke Høiland-Jørgensen 2018-11-09  3765  }
713c0ba8 Toke Høiland-Jørgensen 2018-11-09  3766  EXPORT_SYMBOL(ieee80211_txq_schedule_end);
713c0ba8 Toke Høiland-Jørgensen 2018-11-09  3767  

:::::: The code at line 3751 was first introduced by commit
:::::: 713c0ba81183867042981a05259f4910183c5c4f mac80211: Add TXQ scheduling API

:::::: TO: Toke Høiland-Jørgensen <toke@xxxxxxx>
:::::: CC: 0day robot <lkp@xxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux