On 11/12/2018 6:27, Arend van Spriel wrote: > On 11/12/2018 11:24 AM, Chi-Hsien Lin wrote: >> >> >> On 11/12/2018 6:16, Arend van Spriel wrote: >>> On 11/12/2018 8:29 AM, Chi-Hsien Lin wrote: >>>> GCI core is needed for ULP operation. Allow GCI core enumuration with >>>> below changes: >>>> - Allow GCI to be added to core list even when it doesn't have a >>>> wrapper. >>>> - Allow 8K address space size. >>>> - Don't overwrite the address value when an additional size descriptor >>>> is in place. >>> >>> One question. This only assures the GCI core is listed. So does the >>> driver need to access it for ULP operation? >> >> Yes, the GCI core registers are accessed when entering/exiting ULP sleep >> modes. There will be other patches for the ULP support. > > Yeah. I suspected such. It would have been better to send this patch > with that ULP series, but let's not make it an issue now. The patch is > fine. Thanks a lot. :) > > Regards, > Arend > > . >
