Hello Tamizh,
> > > Co-Developed-by: Tamizh Chelvam <tamizhr@xxxxxxxxxxxxxx>
> > > Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@xxxxxxxxxxxxxx>
> > > Signed-off-by: Tamizh chelvam <tamizhr@xxxxxxxxxxxxxx>
> > > ---
> > > include/net/cfg80211.h | 14 +++++++
> > > include/uapi/linux/nl80211.h | 69 +++++++++++++++++++++++++++++++++
> > > net/wireless/nl80211.c | 86
> > > ++++++++++++++++++++++++++++++++++++++++++
> > > net/wireless/rdev-ops.h | 15 ++++++++
> > > net/wireless/trace.h | 27 +++++++++++++
> > > 5 files changed, 211 insertions(+)
...
> > > /**
> > > @@ -4035,6 +4044,9 @@ struct wiphy_iftype_ext_capab {
> > > * @txq_limit: configuration of internal TX queue frame limit
> > > * @txq_memory_limit: configuration internal TX queue memory limit
> > > * @txq_quantum: configuration of internal TX queue scheduler quantum
> > > + *
> > > + * @max_data_retry_count: Maximum limit can be configured as retry
> > > count
> > > + * for a TID.
> > > */
> > > struct wiphy {
> > > /* assign these fields before you register the wiphy */
> > > @@ -4171,6 +4183,8 @@ struct wiphy {
> > > u32 txq_memory_limit;
> > > u32 txq_quantum;
> > >
> > > + u8 max_data_retry_count;
> > > +
> > > char priv[0] __aligned(NETDEV_ALIGN);
> > > };
> >
> > Could you please clarify why do you define max_data_retry_count instead
> > of
> > making use of existing wiphy params: retry_short (dot11ShortRetryLimit)
> > and retry_long (dot11LongRetryLimit) ?
>
> max_data_retry_count added to validate the max limit for the retry count
> supported by the driver.
> existing wiphy parames: retry_short and retry_long can be modified
> through user command.
> So, I've added this param for validation purpose. Correct me If I'm
> wrong.
Well, but then it probably makes sense to use max_data_retry_count value
to validate retry_short and retry_long values in nl80211_set_wiphy.
Regards,
Sergey
