On 11/5/2018 9:27 PM, Joe Perches wrote: > On Mon, 2018-11-05 at 12:18 +0000, Ajay.Kathat@xxxxxxxxxxxxx wrote: >> Hi Joe, >> >> On 11/5/2018 4:27 PM, Joe Perches wrote: >>> On Thu, 2018-11-01 at 16:45 +0000, Ajay.Kathat@xxxxxxxxxxxxx wrote: >>>> From: Ajay Singh <ajay.kathat@xxxxxxxxxxxxx> >>>> >>>> Use shorter name for 'network_info' variable to avoid line over 80 chars >>>> issue. >>> I suppose this is OK, though perhaps unnecessary. >>> >>> As well, perhaps there are defects in the original code >>> in a couple places. >>> >>>> diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c >>> [] >>>> - network_info->tsf_hi = le64_to_cpu(mgt->u.beacon.timestamp); >>>> - network_info->tsf_lo = (u32)network_info->tsf_hi; >>> Perhaps there is a defect for both tsf_hi assignments >>> as it appears as if both are missing ">> 32" >> Actually, 'tsf_hi' is used to store the complete tsf value as its data >> type is u64. This value is pass to the cfg80211_inform_bss() as it is. >> So the conversion of 'tsf_hi' to 32 bit is not required in this case. > Antipattern naming generally warrants a rename. > Thanks Joe. Sure, I will rename tsf_hi in future patch to have clear meaning. Regards, Ajay
