Search Linux Wireless

Re: [PATCH v2 3/3] b43: Use cordic algorithm from kernel library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/5/2018 10:39 PM, Michael Büsch wrote:
On Mon,  5 Nov 2018 21:37:18 +0200
Priit Laes <plaes@xxxxxxxxx> wrote:

Kernel library has a common cordic algorithm which is identical
to internally implementatd one, so use it and drop the duplicate
implementation.

Signed-off-by: Priit Laes <plaes@xxxxxxxxx>


This looks nice.
But what is the testing status of this?
Has this been tested on actual b43-LP hardware?

Is the replacement algorithm exactly the same, or are there slight
differences (e.g. in corner cases)?

Hi Michael,

I recall doing a comparison between the algorithms and thought I put that in the original commit message. However, it is not there. It is not exactly the same as in b43 so there are difference for certain angles, most results are the same however. This implementation is slightly more accurate on the full scale.





[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux