Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > I had a couple concerns with this code. First, we definitely need to > set the error code if the kzalloc() fails. Secondly, I was worried that > if we didn't set "arsta->tx_stats" to NULL after freeing it, then it > looks to me like it might lead to a use after free. I can't test that, > but it's harmless to set it to NULL so I did. > > Fixes: a904417fc876 ("ath10k: add extended per sta tx statistics support") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx> Patch applied to ath-next branch of ath.git, thanks. 539b44e70c5b ath10k: fixup extended per sta tx statistics -- https://patchwork.kernel.org/patch/10646825/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches