Search Linux Wireless

Re: [PATCH 5/5] b43: Drop internal cordic algorithm implementation

To: Kalle Valo <kvalo@xxxxxxxxxxxxxx>, Priit Laes <plaes@xxxxxxxxx>
Subject: Re: [PATCH 5/5] b43: Drop internal cordic algorithm implementation
From: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>
Date: Mon, 5 Nov 2018 10:11:41 +0100
Cc: linux-kernel@xxxxxxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, linux-wireless@xxxxxxxxxxxxxxx, b43-dev@xxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx
In-reply-to: <87y3a7gaag.fsf@codeaurora.org>
References: <cover.f21c8e62e188620d586edb3f77514e6237122c4c.1541238842.git-series.plaes@plaes.org> <51f98dbd0efe48c315d8e7876074aeaa22fde580.1541238842.git-series.plaes@plaes.org> <87y3a7gaag.fsf@codeaurora.org>
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

On 11/5/2018 10:09 AM, Kalle Valo wrote:

Priit Laes <plaes@xxxxxxxxx> writes:

Signed-off-by: Priit Laes <plaes@xxxxxxxxx>


No empty commit logs, please.

And IMHO you could fold patch 5 into patch 4.


Similarly 2 and 3.

Regards,
Arend

References:
- [PATCH 0/5] Use common cordic algorithm for b43
  - From: Priit Laes
- [PATCH 5/5] b43: Drop internal cordic algorithm implementation
  - From: Priit Laes
- Re: [PATCH 5/5] b43: Drop internal cordic algorithm implementation
  - From: Kalle Valo