On Wed, 2018-10-31 at 18:12 +0800, yhchuang@xxxxxxxxxxx wrote > From: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx> > debug files for Realtek 802.11ac wireless network chips [] > diff --git a/drivers/net/wireless/realtek/rtw88/debug.h b/drivers/net/wireless/realtek/rtw88/debug.h [] > +#ifdef CONFIG_RTW88_DEBUG [] > +#else > + > +static inline void rtw_dbg(struct rtw_dev *rtwdev, const char *fmt, ...) {} > +static inline void rtw_info(struct rtw_dev *rtwdev, const char *fmt, ...) {} > +static inline void rtw_warn(struct rtw_dev *rtwdev, const char *fmt, ...) {} > +static inline void rtw_err(struct rtw_dev *rtwdev, const char *fmt, ...) {} I still think it's _very, very bad_, and extremely unusual to turn off _all_ logging, even for error conditions, based on a debug config flag.