On 2018/10/30 下午 07:33, Arend van Spriel wrote: > On 10/29/2018 11:27 AM, Wright Feng wrote: >> This patch is for adding a new module parameter "frameburst". >> With setting "frameburst=1" in module parameters, firmware frameburst >> mode >> will be enabled. The feature can enable per-packet framebursting in >> firmware side and get higher TX throughput in High Throughput(HT) mode. > > I am not sure about every firmware image, but in recent branches here I > see firmware enables frameburst by default. So not sure about the > motivation to add this. You could also consider adding this to the > nl80211 api. I am sure other vendors have similar features. > > Regards, > Arend > The newer firmware may set firmware by default, but Some firmwares in upstream do not, like 7.35.349.28 for 4354-sdio. Before adding new API in ops and ATTR in nl80211, I think keeping the frameburst module parameter is good for user to enhance TX throughput. And I will find time to add new API after finishing my internal task. -Wright >> Signed-off-by: Wright Feng <wright.feng@xxxxxxxxxxx> >> --- >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 7 +++++++ >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 5 +++++ >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.h | 2 ++ >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h | 1 + >> 4 files changed, 15 insertions(+) >
