Search Linux Wireless

Re: [PATCH 5/4] rfkill: query EV_SW states when rfkill-input connects to a input device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Henrique,

On Thu, Jul 17, 2008 at 06:56:54PM -0300, Henrique de Moraes Holschuh wrote:
> Every time a new input device that is capable of one of the rfkill EV_SW
> events (currently only SW_RFKILL_ALL) is connected to rfkill-input, we must
> check the switch state and take action.
> 
> Otherwise, we will ignore the initial switch state.
> 

I think this task is more suited for the ->start() method of the input
handler. This way, if userspace grabs the switch input device and then
releases it rfkill will get a chance to re-synchronize with the switch
state.

Also I think it would be a good idea to take input_dev->event_lock
while scheduling the state change so that the switch state does not
change underneath you.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux