On Mon, Oct 29, 2018 at 04:25:31PM +0200, Kalle Valo wrote: > Stanislaw Gruszka <sgruszka@xxxxxxxxxx> writes: > > > If we are associated and scanning is performed , sw_scan_complete callback > > is done after we get back to operating channel, so we do not perform > > phy calibration and queue cal work. Fix this by run calibration from > > sw_scan_complete(). > > > > Fixes: bbd10586f0df ("mt76x0: phy: do not run calibration during channel switch") > > Signed-off-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx> > > --- > > This is for 4.20 > > So what are the symptoms from user's point of view? Is this a > regression? We do not perform gain calibration any longer if somebody will request scan after association. This is formally a regression, but calibration code changed a lot, so perhaps this can be dropped for 4.20 and eventually go through -stable if I can confirm it fixes performance problems. Thanks Stanislaw