On Sun, Oct 28, 2018 at 02:46:24PM +0100, Marcel Holtmann wrote: > >> +#define VERSION "0.1" > > > > We don't version kernel drivers individually, so please drop this here > > and below. > > if we don’t then maybe send patches to remove MODULE_VERSION first. > Otherwise this is totally fine to do. > > There are currently 670 usages of MODULE_VERSION and I have not heard > anybody looking at removing this. Should have phrased that differently; versioning modules individually does not make much sense when we already have a kernel version which is tied to the driver code in question and which *does* get updated as new kernels are released (unlike these module version defines, which tend to stay unchanged). For USB, we've dropped module versioning entirely and push back whenever someone proposes to add it back. Other subsystems and particularly old drivers may still have these macros of course. In this case, the pn533 driver (and its interface drivers) is one of only three NFC drivers which have MODULE_VERSION, but maybe it makes sense to keep it in, if only for consistency with the other pn533 components. Thanks, Johan
