On Friday 18 July 2008, Johannes Berg wrote: > On Fri, 2008-07-18 at 20:45 +0200, Ivo van Doorn wrote: > > The aifs type has recently been changed to unsigned, > > this triggered the following gcc warning: > > > > CC [M] drivers/net/wireless/rt2x00/rt2x00mac.o > > drivers/net/wireless/rt2x00/rt2x00mac.c: In function 'rt2x00mac_conf_tx': > > drivers/net/wireless/rt2x00/rt2x00mac.c:557: warning: comparison is always true due to limited range of data type > > > > Signed-off-by: Ivo van Doorn <IvDoorn@xxxxxxxxx> > > --- > > drivers/net/wireless/rt2x00/rt2x00mac.c | 5 +---- > > 1 files changed, 1 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/wireless/rt2x00/rt2x00mac.c b/drivers/net/wireless/rt2x00/rt2x00mac.c > > index 77af1df..f1dcbaa 100644 > > --- a/drivers/net/wireless/rt2x00/rt2x00mac.c > > +++ b/drivers/net/wireless/rt2x00/rt2x00mac.c > > @@ -554,10 +554,7 @@ int rt2x00mac_conf_tx(struct ieee80211_hw *hw, u16 queue_idx, > > else > > queue->cw_max = 10; /* cw_min: 2^10 = 1024. */ > > > > - if (params->aifs >= 0) > > - queue->aifs = params->aifs; > > - else > > - queue->aifs = 2; > > + queue->aifs = params->aifs; > > davem already took my patch doing exactly that into his tree, it just > hasn't arrived back yet. Oh, I must have missed that patch then. :) I've found it in your patch directory as well now, John, please skip this patch Ivo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
