On Wed, 2018-10-17 at 22:58 +0200, Johannes Berg wrote: > On Wed, 2018-10-17 at 14:00 -0700, James Prestwood wrote: > > > > > That makes me wonder if you'd also want to support limiting the # > > > of > > > interfaces/channels to mimic another device? > > > > Yeah it seems like it would be pretty easy to add that on top of > > this > > change, although I don't really see us actually using it. > > Sure, fair enough. > > > I can add it, > > but my only concern is I would not test it up to the same level I > > tested iftype/ciphers. > > If you don't really want to use it, then I don't think you need to > add > it. I was just wondering if it made a difference. > > > Maybe this is also because I am not entirely > > sure what num_different_channels is doing. Is this only relevant > > when > > multiple interfaces exist on a radio? Like setting how many > > channels > > can be use simultaneously? > > Correct. "Simultaneously" is a bit of an overstatement, typically > today > it's implemented by TDM - if you have two interfaces with a > connection > to an AP each, but on different channels, each interface would just > tell > its AP that it's going to sleep, but instead hop to the other channel > and tell that AP that it woke up... etc. Ah ok, that makes sense. Ok, well I can fixup that typo, as well as reordering the use_chanctx stuff I mentioned. Unless there was anything else? If not I can submit v3. > > johannes >