Search Linux Wireless

Re: [PATCH] ath10k: Fill the channel survey results for WCN3990 correctly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Kalle,

I have removed the clk_freq variable and now there will be u32 division only.
This change has been sent in v2.

Thanks,
Rakesh Pillai.

On 2018-10-12 21:23, Kalle Valo wrote:
Kalle Valo <kvalo@xxxxxxxxxxxxxx> writes:

Rakesh Pillai <pillair@xxxxxxxxxxxxxx> wrote:

The host driver currently expects the channel info event to be
received in pairs for all the channels, i.e. the first
chan_info event for a particular channel will not have the
COMPLETE flag set and the second chan_info event for the
same channel will have the COMPLETE flag set.

The HL2.0 firmware sends only one channel info event per channel
which is scanned without the COMPLETE flag set. After sending the
chan_info_event for all the channels, the HL2.0 firmware sends a
chan_info_event with COMPLETE flag set to indicate the completion
of the channel info event.

The firmware does not indicate this behavior with any service bitmap
and hence a new firmware feature flag is used to handle the modified
parsing of the channel info events, in the host driver, for the
firmware which sends single channel info event per scanned channel.

Tested HW: WCN3990
Tested FW: WLAN.HL.2.0-01188-QCAHLSWMTPLZ-1

Co-developed-by: Surabhi Vishnoi <svishnoi@xxxxxxxxxxxxxx>
Signed-off-by: Surabhi Vishnoi <svishnoi@xxxxxxxxxxxxxx>
Signed-off-by: Rakesh Pillai <pillair@xxxxxxxxxxxxxx>
Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx>

Kbuild bot reported some errors:

ERROR: "__udivdi3" [drivers/net/wireless/ath/ath10k/ath10k_core.ko] undefined! ERROR: "__divdi3" [drivers/net/wireless/ath/ath10k/ath10k_core.ko] undefined!

Need to investigate those if they are valid or problem with the bot.

Arnd explained the problem in the other thread:

  "I think the problem is that 'clock_freq' is a 'u64', which means we
   can't use a normal 32-bit division. It looks like it cannot actually
   go beyond the range of a u32, so changing the type should be
   sufficient."

Please investigate that and submit v2.



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux