Search Linux Wireless

Re: [RFC v3 01/12] rtw88: main files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tony Chuang <yhchuang@xxxxxxxxxxx> writes:

>> > +static void rtw_watch_dog_work(struct work_struct *work)
>> > +{
>> > +	struct rtw_dev *rtwdev = container_of(work, struct rtw_dev,
>> > +					      watch_dog_work.work);
>> > +	struct rtw_vif *rtwvif;
>> > +
>> > +	if (!rtw_flag_check(rtwdev, RTW_FLAG_RUNNING))
>> > +		return;
>> > +
>> > +	ieee80211_queue_delayed_work(rtwdev->hw,
>> &rtwdev->watch_dog_work,
>> > +				     RTW_WATCH_DOG_DELAY_TIME);
>> 
>> You're aware of the power cost of waking up every 2 seconds? That's a
>> really bad idea, in general, at the very least you should use a more
>> power efficient scheduling here to combine with other wakeups
>> (round_jiffies_relative, or so).
>
> Yeah I knew it, but so far we can only work like this...
> Will use round_jiffies_relative to combine the CPU wakeups.

Can you elaborate more why this horrible timer is needed? And it
definitely needs a comment in the code explaining the reason.

-- 
Kalle Valo



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux