Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> writes: > On 10/10/2018 9:28 AM, Hans de Goede wrote: >> So how do you want to proceed with this, do you want me to just >> put the full ISC text in the header for now as the rest of brcmfmac >> does? > > This is not entirely true as far as I know. I assume you are referring > to this: > > /* > * Copyright (c) 2010 Broadcom Corporation > * > * Permission to use, copy, modify, and/or distribute this software for any > * purpose with or without fee is hereby granted, provided that the above > * copyright notice and this permission notice appear in all copies. > * > * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES > * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF > * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE > FOR ANY > * SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES > * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN > AN ACTION > * OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN > * CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. > */ > > As far as I recall we opted for BSD license and ISC is equivalent. Oh, sorry for missing that. > However, The BSD license are already in place so why not use that. I > would say BSD-2-Clause should cover it. As this is a new file I guess > it is up to you although I would prefer to stick with a permissive > license. >From maintainer's point of view I very much prefer that a driver uses the same license in all files. It's very confusing if the license changes within different files. -- Kalle Valo