Hans de Goede <hdegoede@xxxxxxxxxx> writes: > Hi, > > On 10-10-18 09:09, Kalle Valo wrote: >> Hans de Goede <hdegoede@xxxxxxxxxx> writes: >> >>> For x86 based machines, set the board_type used for nvram file selection >>> based on the DMI sys-vendor and product-name strings. >>> >>> Since on some models these strings are too generic, this commit also adds >>> a quirk table overriding the strings for models listed in that table. >>> >>> The board_type setting is used to load the board-specific nvram file with >>> a board-specific name so that we can ship files for each supported board >>> in linux-firmware. >>> >>> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> >> >> [...] >> >>> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c >>> @@ -0,0 +1,104 @@ >>> +// SPDX-License-Identifier: ISC >> >> I don't see the ISC file in LICENSES directory[1] and I don't feel >> comfortable taking SPDX tags which which don't have a license file. > > Ok. I need to do a patch for the LICENSES directory anyways, so I will > also submit the ISC license upstream while at it, I will hopefully > get around to doing that today. That would be awesome, thanks! Then I could do the SPDX conversion also on ath10k. > So how do you want to proceed with this, do you want me to just > put the full ISC text in the header for now as the rest of brcmfmac > does? Yeah, I think this is the fastest way. > Then later someone (me if I get around to it) can replace all of > the headers with // SPDX-License-Identifier: ISC once it has been > added under LICENSES. Sounds good to me. -- Kalle Valo
