Re: [PATCH v2 1/4] rt2x00: remove unneeded check

kbuild test robot <lkp@xxxx · Wed, 10 Oct 2018 10:47:18

   Hi Tomislav,

Thank you for the patch! Yet something to

[auto build test ERROR on wireless-drivers-next/m [also build test ERROR on v4.19-rc7 next-20181009 [if your patch is applied to the wrong git

url:    Description: application/gzip

m/pagead/js/adsbygoogle.js"> ht:90px" ; xxxxxxxxx> rt2x00: remove unneeded check xxxxx> +0800 s@xxxxxxxxxxxxxxx,        Daniel Golle <daniel@xxxxxxxxxxxxxx>, Mathias Kresin <dev@xxxxxxxxx>,        Felix Fietkau <nbd@xxxxxxxx>,        Tomislav Požega <pozega.tomislav@xxxxxxxxx> html">1539082867-4264-1-git-send-email-sgruszka@redhat.com> tml">1539082867-4264-1-git-send-email-sgruszka@redhat.com>  "> /a> com/js/300/addthis_widget.js#pubid=ra-5196c2ae1be43d18&async=1&domready=1" async> m/pagead/js/adsbygoogle.js"> ; improve: aster] ] tree, please drop us a note to help improve the system] om/0day-ci/linux/commits/Stanislaw-Gruszka/rt2x00-remove-unneeded-check/20181010-012334">https://github.com/0day-ci/linux/commits/Stanislaw-Gruszka/rt2x00-remove-unneeded-check/20181010-012334 el.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git">https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master as .config) (experimental) .githubusercontent.com/intel/lkp-tests/master/sbin/make.cross">https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross build tree In function 'rt2800_config_channel_rf3290': warning: unused variable 'idx' [-Wunused-variable] In function 'rt2800_config_channel_rf53xx': 0lib.c:3016:20: error: 'idx' undeclared (first use in this function) note: each undeclared identifier is reported only once for each function it appears in 0/rt2800lib.c Stanislaw Gruszka 2013-03-16  2875 Woody Hung        2012-06-13  2876  static void rt2800_config_channel_rf3290(struct rt2x00_dev *rt2x00dev, Woody Hung        2012-06-13  2877  					 struct ieee80211_conf *conf, Woody Hung        2012-06-13  2878  					 struct rf_channel *rf, Woody Hung        2012-06-13  2879  					 struct channel_info *info) Woody Hung        2012-06-13  2880  { Tomislav Požega   2018-10-09 @2881  	int idx = rf->channel-1; Woody Hung        2012-06-13  2882  	u8 rfcsr; Woody Hung        2012-06-13  2883 Woody Hung        2012-06-13  2884  	rt2800_rfcsr_write(rt2x00dev, 8, rf->rf1); Woody Hung        2012-06-13  2885  	rt2800_rfcsr_write(rt2x00dev, 9, rf->rf3); Arnd Bergmann     2017-05-17  2886  	rfcsr = rt2800_rfcsr_read(rt2x00dev, 11); Woody Hung        2012-06-13  2887  	rt2x00_set_field8(&rfcsr, RFCSR11_R, rf->rf2); Woody Hung        2012-06-13  2888  	rt2800_rfcsr_write(rt2x00dev, 11, rfcsr); Woody Hung        2012-06-13  2889 Arnd Bergmann     2017-05-17  2890  	rfcsr = rt2800_rfcsr_read(rt2x00dev, 49); Stanislaw Gruszka 2012-07-09  2891  	if (info->default_power1 > POWER_BOUND) Stanislaw Gruszka 2012-07-09  2892  		rt2x00_set_field8(&rfcsr, RFCSR49_TX, POWER_BOUND); Woody Hung        2012-06-13  2893  	else Woody Hung        2012-06-13  2894  		rt2x00_set_field8(&rfcsr, RFCSR49_TX, info->default_power1); Woody Hung        2012-06-13  2895  	rt2800_rfcsr_write(rt2x00dev, 49, rfcsr); Woody Hung        2012-06-13  2896 Stanislaw Gruszka 2016-12-19  2897  	rt2800_freq_cal_mode1(rt2x00dev); Woody Hung        2012-06-13  2898 Woody Hung        2012-06-13  2899  	if (rf->channel <= 14) { Woody Hung        2012-06-13  2900  		if (rf->channel == 6) Woody Hung        2012-06-13  2901  			rt2800_bbp_write(rt2x00dev, 68, 0x0c); Woody Hung        2012-06-13  2902  		else Woody Hung        2012-06-13  2903  			rt2800_bbp_write(rt2x00dev, 68, 0x0b); Woody Hung        2012-06-13  2904 Woody Hung        2012-06-13  2905  		if (rf->channel >= 1 && rf->channel <= 6) Woody Hung        2012-06-13  2906  			rt2800_bbp_write(rt2x00dev, 59, 0x0f); Woody Hung        2012-06-13  2907  		else if (rf->channel >= 7 && rf->channel <= 11) Woody Hung        2012-06-13  2908  			rt2800_bbp_write(rt2x00dev, 59, 0x0e); Woody Hung        2012-06-13  2909  		else if (rf->channel >= 12 && rf->channel <= 14) Woody Hung        2012-06-13  2910  			rt2800_bbp_write(rt2x00dev, 59, 0x0d); Woody Hung        2012-06-13  2911  	} Woody Hung        2012-06-13  2912  } Woody Hung        2012-06-13  2913 Daniel Golle      2012-09-09  2914  static void rt2800_config_channel_rf3322(struct rt2x00_dev *rt2x00dev, Daniel Golle      2012-09-09  2915  					 struct ieee80211_conf *conf, Daniel Golle      2012-09-09  2916  					 struct rf_channel *rf, Daniel Golle      2012-09-09  2917  					 struct channel_info *info) Daniel Golle      2012-09-09  2918  { Daniel Golle      2012-09-09  2919  	u8 rfcsr; Daniel Golle      2012-09-09  2920 Daniel Golle      2012-09-09  2921  	rt2800_rfcsr_write(rt2x00dev, 8, rf->rf1); Daniel Golle      2012-09-09  2922  	rt2800_rfcsr_write(rt2x00dev, 9, rf->rf3); Daniel Golle      2012-09-09  2923 Daniel Golle      2012-09-09  2924  	rt2800_rfcsr_write(rt2x00dev, 11, 0x42); Daniel Golle      2012-09-09  2925  	rt2800_rfcsr_write(rt2x00dev, 12, 0x1c); Daniel Golle      2012-09-09  2926  	rt2800_rfcsr_write(rt2x00dev, 13, 0x00); Daniel Golle      2012-09-09  2927 Daniel Golle      2012-09-09  2928  	if (info->default_power1 > POWER_BOUND) Daniel Golle      2012-09-09  2929  		rt2800_rfcsr_write(rt2x00dev, 47, POWER_BOUND); Daniel Golle      2012-09-09  2930  	else Daniel Golle      2012-09-09  2931  		rt2800_rfcsr_write(rt2x00dev, 47, info->default_power1); Daniel Golle      2012-09-09  2932 Daniel Golle      2012-09-09  2933  	if (info->default_power2 > POWER_BOUND) Daniel Golle      2012-09-09  2934  		rt2800_rfcsr_write(rt2x00dev, 48, POWER_BOUND); Daniel Golle      2012-09-09  2935  	else Daniel Golle      2012-09-09  2936  		rt2800_rfcsr_write(rt2x00dev, 48, info->default_power2); Daniel Golle      2012-09-09  2937 Stanislaw Gruszka 2016-12-19  2938  	rt2800_freq_cal_mode1(rt2x00dev); Daniel Golle      2012-09-09  2939 Arnd Bergmann     2017-05-17  2940  	rfcsr = rt2800_rfcsr_read(rt2x00dev, 1); Daniel Golle      2012-09-09  2941  	rt2x00_set_field8(&rfcsr, RFCSR1_RX0_PD, 1); Daniel Golle      2012-09-09  2942  	rt2x00_set_field8(&rfcsr, RFCSR1_TX0_PD, 1); Daniel Golle      2012-09-09  2943 Daniel Golle      2012-09-09  2944  	if ( rt2x00dev->default_ant.tx_chain_num == 2 ) Daniel Golle      2012-09-09  2945  		rt2x00_set_field8(&rfcsr, RFCSR1_TX1_PD, 1); Daniel Golle      2012-09-09  2946  	else Daniel Golle      2012-09-09  2947  		rt2x00_set_field8(&rfcsr, RFCSR1_TX1_PD, 0); Daniel Golle      2012-09-09  2948 Daniel Golle      2012-09-09  2949  	if ( rt2x00dev->default_ant.rx_chain_num == 2 ) Daniel Golle      2012-09-09  2950  		rt2x00_set_field8(&rfcsr, RFCSR1_RX1_PD, 1); Daniel Golle      2012-09-09  2951  	else Daniel Golle      2012-09-09  2952  		rt2x00_set_field8(&rfcsr, RFCSR1_RX1_PD, 0); Daniel Golle      2012-09-09  2953 Daniel Golle      2012-09-09  2954  	rt2x00_set_field8(&rfcsr, RFCSR1_RX2_PD, 0); Daniel Golle      2012-09-09  2955  	rt2x00_set_field8(&rfcsr, RFCSR1_TX2_PD, 0); Daniel Golle      2012-09-09  2956 Daniel Golle      2012-09-09  2957  	rt2800_rfcsr_write(rt2x00dev, 1, rfcsr); Daniel Golle      2012-09-09  2958 Daniel Golle      2012-09-09  2959  	rt2800_rfcsr_write(rt2x00dev, 31, 80); Daniel Golle      2012-09-09  2960  } Daniel Golle      2012-09-09  2961 RA-Shiang Tu      2011-02-20  2962  static void rt2800_config_channel_rf53xx(struct rt2x00_dev *rt2x00dev, RA-Shiang Tu      2011-02-20  2963  					 struct ieee80211_conf *conf, RA-Shiang Tu      2011-02-20  2964  					 struct rf_channel *rf, RA-Shiang Tu      2011-02-20  2965  					 struct channel_info *info) RA-Shiang Tu      2011-02-20  2966  { RA-Shiang Tu      2011-02-20  2967  	u8 rfcsr; RA-Shiang Tu      2011-02-20  2968 RA-Shiang Tu      2011-02-20  2969  	rt2800_rfcsr_write(rt2x00dev, 8, rf->rf1); RA-Shiang Tu      2011-02-20  2970  	rt2800_rfcsr_write(rt2x00dev, 9, rf->rf3); Arnd Bergmann     2017-05-17  2971  	rfcsr = rt2800_rfcsr_read(rt2x00dev, 11); RA-Shiang Tu      2011-02-20  2972  	rt2x00_set_field8(&rfcsr, RFCSR11_R, rf->rf2); RA-Shiang Tu      2011-02-20  2973  	rt2800_rfcsr_write(rt2x00dev, 11, rfcsr); RA-Shiang Tu      2011-02-20  2974 Arnd Bergmann     2017-05-17  2975  	rfcsr = rt2800_rfcsr_read(rt2x00dev, 49); Stanislaw Gruszka 2012-07-09  2976  	if (info->default_power1 > POWER_BOUND) Stanislaw Gruszka 2012-07-09  2977  		rt2x00_set_field8(&rfcsr, RFCSR49_TX, POWER_BOUND); RA-Shiang Tu      2011-02-20  2978  	else RA-Shiang Tu      2011-02-20  2979  		rt2x00_set_field8(&rfcsr, RFCSR49_TX, info->default_power1); RA-Shiang Tu      2011-02-20  2980  	rt2800_rfcsr_write(rt2x00dev, 49, rfcsr); RA-Shiang Tu      2011-02-20  2981 Zero.Lin          2012-05-29  2982  	if (rt2x00_rt(rt2x00dev, RT5392)) { Arnd Bergmann     2017-05-17  2983  		rfcsr = rt2800_rfcsr_read(rt2x00dev, 50); Felipe Pena       2013-10-18  2984  		if (info->default_power2 > POWER_BOUND) Stanislaw Gruszka 2012-07-09  2985  			rt2x00_set_field8(&rfcsr, RFCSR50_TX, POWER_BOUND); Zero.Lin          2012-05-29  2986  		else Zero.Lin          2012-05-29  2987  			rt2x00_set_field8(&rfcsr, RFCSR50_TX, Zero.Lin          2012-05-29  2988  					  info->default_power2); Zero.Lin          2012-05-29  2989  		rt2800_rfcsr_write(rt2x00dev, 50, rfcsr); Zero.Lin          2012-05-29  2990  	} Zero.Lin          2012-05-29  2991 Arnd Bergmann     2017-05-17  2992  	rfcsr = rt2800_rfcsr_read(rt2x00dev, 1); Zero.Lin          2012-05-29  2993  	if (rt2x00_rt(rt2x00dev, RT5392)) { Zero.Lin          2012-05-29  2994  		rt2x00_set_field8(&rfcsr, RFCSR1_RX1_PD, 1); Zero.Lin          2012-05-29  2995  		rt2x00_set_field8(&rfcsr, RFCSR1_TX1_PD, 1); Zero.Lin          2012-05-29  2996  	} RA-Shiang Tu      2011-02-20  2997  	rt2x00_set_field8(&rfcsr, RFCSR1_RF_BLOCK_EN, 1); RA-Shiang Tu      2011-02-20  2998  	rt2x00_set_field8(&rfcsr, RFCSR1_PLL_PD, 1); RA-Shiang Tu      2011-02-20  2999  	rt2x00_set_field8(&rfcsr, RFCSR1_RX0_PD, 1); RA-Shiang Tu      2011-02-20  3000  	rt2x00_set_field8(&rfcsr, RFCSR1_TX0_PD, 1); RA-Shiang Tu      2011-02-20  3001  	rt2800_rfcsr_write(rt2x00dev, 1, rfcsr); RA-Shiang Tu      2011-02-20  3002 Stanislaw Gruszka 2016-12-19  3003  	rt2800_freq_cal_mode1(rt2x00dev); RA-Shiang Tu      2011-02-20  3004 Gabor Juhos       2013-10-11  3005  	if (rt2x00_has_cap_bt_coexist(rt2x00dev)) { RA-Shiang Tu      2011-02-20  3006  		if (rt2x00_rt_rev_gte(rt2x00dev, RT5390, REV_RT5390F)) { RA-Shiang Tu      2011-02-20  3007  			/* r55/r59 value array of channel 1~14 */ RA-Shiang Tu      2011-02-20  3008  			static const char r55_bt_rev[] = {0x83, 0x83, RA-Shiang Tu      2011-02-20  3009  				0x83, 0x73, 0x73, 0x63, 0x53, 0x53, RA-Shiang Tu      2011-02-20  3010  				0x53, 0x43, 0x43, 0x43, 0x43, 0x43}; RA-Shiang Tu      2011-02-20  3011  			static const char r59_bt_rev[] = {0x0e, 0x0e, RA-Shiang Tu      2011-02-20  3012  				0x0e, 0x0e, 0x0e, 0x0b, 0x0a, 0x09, RA-Shiang Tu      2011-02-20  3013  				0x07, 0x07, 0x07, 0x07, 0x07, 0x07}; RA-Shiang Tu      2011-02-20  3014 Gabor Juhos       2011-03-03  3015  			rt2800_rfcsr_write(rt2x00dev, 55, Gabor Juhos       2011-03-03 @3016  					   r55_bt_rev[idx]); Gabor Juhos       2011-03-03  3017  			rt2800_rfcsr_write(rt2x00dev, 59, Gabor Juhos       2011-03-03  3018  					   r59_bt_rev[idx]); RA-Shiang Tu      2011-02-20  3019  		} else { RA-Shiang Tu      2011-02-20  3020  			static const char r59_bt[] = {0x8b, 0x8b, 0x8b, RA-Shiang Tu      2011-02-20  3021  				0x8b, 0x8b, 0x8b, 0x8b, 0x8a, 0x89, RA-Shiang Tu      2011-02-20  3022  				0x88, 0x88, 0x86, 0x85, 0x84}; RA-Shiang Tu      2011-02-20  3023 RA-Shiang Tu      2011-02-20  3024  			rt2800_rfcsr_write(rt2x00dev, 59, r59_bt[idx]); RA-Shiang Tu      2011-02-20  3025  		} RA-Shiang Tu      2011-02-20  3026  	} else { RA-Shiang Tu      2011-02-20  3027  		if (rt2x00_rt_rev_gte(rt2x00dev, RT5390, REV_RT5390F)) { RA-Shiang Tu      2011-02-20  3028  			static const char r55_nonbt_rev[] = {0x23, 0x23, RA-Shiang Tu      2011-02-20  3029  				0x23, 0x23, 0x13, 0x13, 0x03, 0x03, RA-Shiang Tu      2011-02-20  3030  				0x03, 0x03, 0x03, 0x03, 0x03, 0x03}; RA-Shiang Tu      2011-02-20  3031  			static const char r59_nonbt_rev[] = {0x07, 0x07, RA-Shiang Tu      2011-02-20  3032  				0x07, 0x07, 0x07, 0x07, 0x07, 0x07, RA-Shiang Tu      2011-02-20  3033  				0x07, 0x07, 0x06, 0x05, 0x04, 0x04}; RA-Shiang Tu      2011-02-20  3034 Gabor Juhos       2011-03-03  3035  			rt2800_rfcsr_write(rt2x00dev, 55, Gabor Juhos       2011-03-03  3036  					   r55_nonbt_rev[idx]); Gabor Juhos       2011-03-03  3037  			rt2800_rfcsr_write(rt2x00dev, 59, Gabor Juhos       2011-03-03  3038  					   r59_nonbt_rev[idx]); John Li           2012-02-17  3039  		} else if (rt2x00_rt(rt2x00dev, RT5390) || Roman Yeryomin    2017-03-21  3040  			   rt2x00_rt(rt2x00dev, RT5392) || Roman Yeryomin    2017-03-21  3041  			   rt2x00_rt(rt2x00dev, RT6352)) { RA-Shiang Tu      2011-02-20  3042  			static const char r59_non_bt[] = {0x8f, 0x8f, RA-Shiang Tu      2011-02-20  3043  				0x8f, 0x8f, 0x8f, 0x8f, 0x8f, 0x8d, RA-Shiang Tu      2011-02-20  3044  				0x8a, 0x88, 0x88, 0x87, 0x87, 0x86}; RA-Shiang Tu      2011-02-20  3045 Gabor Juhos       2011-03-03  3046  			rt2800_rfcsr_write(rt2x00dev, 59, Gabor Juhos       2011-03-03  3047  					   r59_non_bt[idx]); Serge Vasilugin   2017-01-20  3048  		} else if (rt2x00_rt(rt2x00dev, RT5350)) { Serge Vasilugin   2017-01-20  3049  			static const char r59_non_bt[] = {0x0b, 0x0b, Serge Vasilugin   2017-01-20  3050  				0x0b, 0x0b, 0x0b, 0x0b, 0x0b, 0x0a, Serge Vasilugin   2017-01-20  3051  				0x0a, 0x09, 0x08, 0x07, 0x07, 0x06}; Serge Vasilugin   2017-01-20  3052 Serge Vasilugin   2017-01-20  3053  			rt2800_rfcsr_write(rt2x00dev, 59, Serge Vasilugin   2017-01-20  3054  					   r59_non_bt[idx]); RA-Shiang Tu      2011-02-20  3055  		} RA-Shiang Tu      2011-02-20  3056  	} RA-Shiang Tu      2011-02-20  3057  } RA-Shiang Tu      2011-02-20  3058 by commit rt2x00: fix whitespace damage in the rt2800 specific code xxxxx> Open Source Technology Center ermail/kbuild-all">https://lists.01.org/pipermail/kbuild-all                   Intel Corporation >.config.gz