On 10/09/2018 12:55 AM, Johannes Berg wrote: > On Tue, 2018-10-09 at 04:23 +0000, Adham.Abozaeid@xxxxxxxxxxxxx wrote: >> >>> I don't know what you need the shadow stuff for, but you should remove >>> it anyway, and use the cfg80211 functionality instead. If not >>> sufficient, propose patches to improve it? >> >> The point behind using a shadow buffer was to keep the scan results >> consistent between consecutive scans, and smooth out the cases where >> an AP isn't found momentarily during scanning. >> In this implementation, APs found during scanning are added to the >> shadow list, and removed if not found again for a period of time. >> >> I'm not much in favour of this implementation neither since it >> complicates the driver's logic, but it was serving the purpose. > > You really should remove it - cfg80211 *and* wpa_s already do this if > required. > > johannes > Thanks Johannes for the tip. I did some research, and I believe you are referring to using bss_expire_age and bss_expire_count. We'll go ahead and remove that. Thanks, Adham
