On Tue, 2018-10-09 at 15:12 +0530, Ajay Singh wrote: > > > +static inline enum sub_frame_type get_sub_type(u8 *header) > > > +{ > > > + return ((enum sub_frame_type)(header[0] & 0xFC)); > > > +} > > > > remove, use include/linux/ieee80211.h. > > > > Did you mean to use '& IEEE80211_FCTL_STYPE' to get the frame sub type, > instead of adding this API. Perhaps, but I suspect you can do mostly with ieee80211_is_probe_resp() and friends. > > > +static inline u8 get_to_ds(u8 *header) > > > +{ > > > + return (header[1] & 0x01); > > > +} > > > + > > > +static inline u8 get_from_ds(u8 *header) > > > +{ > > > + return ((header[1] & 0x02) >> 1); > > > +} > > > > dito > > > > Ack. For this you have ieee80211_has_tods()/_fromds()/_a4() instead. johannes