> -----Original Message----- > From: Johannes Berg [mailto:johannes@xxxxxxxxxxxxxxxx] > Sent: Monday, October 08, 2018 9:29 PM > To: Tony Chuang; kvalo@xxxxxxxxxxxxxx > Cc: Larry.Finger@xxxxxxxxxxxx; Pkshih; Andy Huang; sgruszka@xxxxxxxxxx; > linux-wireless@xxxxxxxxxxxxxxx > Subject: Re: [RFC v3 08/12] rtw88: debug files > > On Wed, 2018-10-03 at 19:20 +0800, yhchuang@xxxxxxxxxxx wrote: > > > > +static struct dentry *debugfs_topdir; > > + > > +void rtw_debugfs_init(struct rtw_dev *rtwdev) > > +{ > > + debugfs_topdir = debugfs_create_dir("rtw88", NULL); > > You really can't do this, all hell will break lose if you ever plug two > devices into the same system. > > johannes > Right, should put it under rtwdev. Yan-Hsuan Chuang