On Sat, 6 Oct 2018 15:45:41 +0300 Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote: > Ajay Singh <ajay.kathat@xxxxxxxxxxxxx> writes: > > > This patch set contains the driver files from > > 'driver/staging/wilc1000'. Renamed the driver from 'wilc1000' to > > 'wilc' to have generic name, as the same driver will be used by > > other wilc family members. > > I'm worried that the name 'wilc' is just too generic, I liked the > original name wilc1000 much more. Quite often when we have a new > generation of wireless devices there's also a new driver, so in the > long run I'm worried that a generic name like 'wilc' could be a > source of confusion. I think it's much smaller problem if > 'wilc1000' (the driver) also supports wilc3000 (the device), people > are already used to that. I also thought about retaining the same wilc1000 name, which has be used for quite some time now. But as we are moving this driver to '/driver/net/wireless/' freshly so thought it’s better to change in the first commit. As you know, 'wilc1000' name is used for folder name as well as module name (i.e wilc1000.ko and wilc1000-spi.ko/wilc1000-sdio.ko). WILC3000 is going to use the same modules(.ko). Do you think its good approach to have 'wilc1000' folder but only remove ‘wilc1000’ prefix from .ko modules names in Makefile (i.e wilc.ko and wilc-spio.ko/wilc-sdio.ko). So these .ko becomes generic and give clear name to be used with both wilc1000 and wilc3000 modules. Please let know what do you think about it and based on your input I will make the change. Also should I submit the v2 version by retaining old name or wait for few more comments to include in that. Regards, Ajay
