> > Felix Fietkau <nbd@xxxxxxxx> writes: > > > Here's another large batch of mt76 code cleanup / deduplication / fixes > > > > - Felix > > > > The following changes since commit e1c02eb16a9c742178874a7d1a08d300981715fb: > > > > qtnfmac: implement dump_station support for STA mode (2018-10-05 14:01:44 +0300) > > > > are available in the Git repository at: > > > > https://github.com/nbd168/wireless tags/mt76-for-kvalo-2018-10-05 > > > > for you to fetch changes up to 06ac97c2e58c7b32bf950ac53976c4260687d386: > > > > mt76x0: pci: report firmware version using ethtool (2018-10-05 20:05:46 +0200) > > > > ---------------------------------------------------------------- > > mt76 patches for 4.20 > > > > * unify code between mt76x0, mt76x2 > > * mt76x0 fixes > > * another fix for rx buffer allocation regression on usb > > * move mt76x2 source files to mt76x2 folder > > * more work on mt76x0e support > > > > ---------------------------------------------------------------- > > I have to drop this as it doesn't build for me: > > drivers/net/wireless/mediatek/mt76/mt76x0/pci_mcu.c: In function 'mt76x0e_load_firmware': > drivers/net/wireless/mediatek/mt76/mt76x0/pci_mcu.c:119:28: error: passing argument 1 of 'mt76x02_set_ethtool_fwver' from incompatible pointer type [-Werror=incompatible-pointer-types] > mt76x02_set_ethtool_fwver(dev, hdr); > ^~~ > In file included from drivers/net/wireless/mediatek/mt76/mt76x0/mcu.h:18:0, > from drivers/net/wireless/mediatek/mt76/mt76x0/pci_mcu.c:20: > drivers/net/wireless/mediatek/mt76/mt76x0/../mt76x02_mcu.h:108:6: note: expected 'struct mt76_dev *' but argument is of type 'struct mt76x02_dev *' > void mt76x02_set_ethtool_fwver(struct mt76_dev *dev, > ^~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors > scripts/Makefile.build:305: recipe for target 'drivers/net/wireless/mediatek/mt76/mt76x0/pci_mcu.o' failed > > -- > Kalle Valo Hi Kalle, I guess we can just drop this patch since it is based on 'use mt76x02_dev instead of mt76_dev as reference' series, sent just as RFC for the moment. I will resend this patch on top of other series. Sorry for the noise Regards, Lorenzo -- UNIX is Sexy: who | grep -i blonde | talk; cd ~; wine; talk; touch; unzip; touch; strip; gasp; finger; gasp; mount; fsck; more; yes; gasp; umount; make clean; sleep