On 2018-10-06 10:25, Lorenzo Bianconi wrote: >> >> PCIe version don't use MCU for RF regsisters access. We need >> to correct RF CSR method to support up to 127 RF registers. >> >> Signed-off-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx> >> --- >> drivers/net/wireless/mediatek/mt76/mt76x0/phy.c | 6 ++---- >> drivers/net/wireless/mediatek/mt76/mt76x02_regs.h | 4 ++-- >> 2 files changed, 4 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c >> index cbbfd5193d9c..da4569f00794 100644 >> --- a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c >> +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c >> @@ -37,7 +37,7 @@ >> bank = MT_RF_BANK(offset); >> reg = MT_RF_REG(offset); >> >> - if (WARN_ON_ONCE(reg > 64) || WARN_ON_ONCE(bank) > 8) >> + if (WARN_ON_ONCE(reg > 127) || WARN_ON_ONCE(bank) > 8) > > I guess there is a typo here, it should be: > > if (WARN_ON_ONCE(reg > 127) || WARN_ON_ONCE(bank > 8)) It's not a regression, since that part is the same as before the patch. Feel free to send a separate fix. - Felix
