On Wed, Oct 03, 2018 at 07:20:55PM +0800, yhchuang@xxxxxxxxxxx wrote: > +static int rtw_debugfs_get_rsvd_page(struct seq_file *m, void *v) > +{ > + struct rtw_debugfs_priv *debugfs_priv = m->private; > + struct rtw_dev *rtwdev = debugfs_priv->rtwdev; > + u8 page_size = rtwdev->chip->page_size; > + u32 buf_size = debugfs_priv->rsvd_page.page_num * page_size; > + u32 offset = debugfs_priv->rsvd_page.page_offset * page_size; > + u8 *buf = vzalloc(buf_size); Error check. > +void rtw_debugfs_init(struct rtw_dev *rtwdev) > +{ > + debugfs_topdir = debugfs_create_dir("rtw88", NULL); You should use rtwdev->hw->wiphy->debugfsdir like other drivers. Thanks Stanislaw