Search Linux Wireless

Re: [RFC v3 08/12] rtw88: debug files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 03, 2018 at 07:20:55PM +0800, yhchuang@xxxxxxxxxxx wrote:
> +static int rtw_debugfs_get_rsvd_page(struct seq_file *m, void *v)
> +{
> +	struct rtw_debugfs_priv *debugfs_priv = m->private;
> +	struct rtw_dev *rtwdev = debugfs_priv->rtwdev;
> +	u8 page_size = rtwdev->chip->page_size;
> +	u32 buf_size = debugfs_priv->rsvd_page.page_num * page_size;
> +	u32 offset = debugfs_priv->rsvd_page.page_offset * page_size;
> +	u8 *buf = vzalloc(buf_size);
Error check.

> +void rtw_debugfs_init(struct rtw_dev *rtwdev)
> +{
> +	debugfs_topdir = debugfs_create_dir("rtw88", NULL);

You should use rtwdev->hw->wiphy->debugfsdir like other drivers.

Thanks
Stanislaw



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux