On Thu, Oct 04, 2018 at 03:02:13PM +0200, Stanislaw Gruszka wrote: > > + WARN(flag, "DBI write fail"); > We always print WARN, there is other return point in this function. > > > +static void rtw_mdio_write(struct rtw_dev *rtwdev, u8 addr, u16 data, bool g1) > <snip> > > + WARN(wflag, "MDIO write fail"); > The same. This is ok, I missed that WARN is printed only conditionally.