Search Linux Wireless

Re: [PATCH net-next 1/2] iwlwifi: compilation error when CONFIG_IWLWIFI_DEBUG is not set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 17, 2008 at 12:19 PM, Denis V. Lunev <den@xxxxxxxxxx> wrote:
> CC [M]  drivers/net/wireless/iwlwifi/iwl-rfkill.o
> drivers/net/wireless/iwlwifi/iwl-led.c: In function 'iwl_led_brightness_set':
> drivers/net/wireless/iwlwifi/iwl-led.c:198: error: 'led_type_str' undeclared (first use in this function)
> drivers/net/wireless/iwlwifi/iwl-led.c:198: error: (Each undeclared identifier is reported only once
> drivers/net/wireless/iwlwifi/iwl-led.c:198: error: for each function it appears in.)
>
> The problem is that led_type_str is defined under CONFIG_IWLWIFI_DEBUG
> while IWL_DEBUG is a static inline function in this case. Replace it
> with macro.
>
> Signed-off-by: Denis V. Lunev <den@xxxxxxxxxx>
> ---
>  drivers/net/wireless/iwlwifi/iwl-debug.h |    8 ++------
>  1 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-debug.h b/drivers/net/wireless/iwlwifi/iwl-debug.h
> index 5838480..d6d729e 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-debug.h
> +++ b/drivers/net/wireless/iwlwifi/iwl-debug.h
> @@ -68,12 +68,8 @@ void iwl_dbgfs_unregister(struct iwl_priv *priv);
>  #endif
>
>  #else
> -static inline void IWL_DEBUG(int level, const char *fmt, ...)
> -{
> -}
> -static inline void IWL_DEBUG_LIMIT(int level, const char *fmt, ...)
> -{
> -}
> +#define IWL_DEBUG(level, fmt, args...)
> +#define IWL_DEBUG_LIMIT(level, fmt, args...)
>  #endif                         /* CONFIG_IWLWIFI_DEBUG */
>
ACK
Tomas
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux