> On Sat, Sep 29, 2018 at 07:30:32PM +0200, Lorenzo Bianconi wrote: > > Add MT_H2M_BBP_AGENT, MT_H2M_MAILBOX_CSR and MT_H2M_INT_SRC and > > remove magic numbers > > > > > > /* TODO: Probably not needed */ > > - mt76_wr(dev, 0x7028, 0); > > - mt76_wr(dev, 0x7010, 0); > > - mt76_wr(dev, 0x7024, 0); > > - msleep(10); > > + mt76_wr(dev, MT_H2M_BBP_AGENT, 0); > > + mt76_wr(dev, MT_H2M_MAILBOX_CSR, 0); > > + mt76_wr(dev, MT_H2M_INT_SRC, 0); > > The same here, I think this should be just removed. ack, will send a patch to remove them > > > + usleep_range(10000, 20000); > > Why this change ? afaik for sleeping less than 20ms it is better to use usleep_range https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/timers/timers-howto.txt Regards, Lorenzo > > Thanks > Stanislaw
