On Wednesday, July 16, 2008 12:27 pm Nick Kossifidis wrote: > 2008/7/16 Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>: > > On Wednesday, July 16, 2008 10:35 am Pavel Roskin wrote: > >> On Wed, 2008-07-16 at 09:31 -0700, Jesse Barnes wrote: > >> > On Wednesday, July 16, 2008 9:15 am Nick Kossifidis wrote: > >> > > It's ok for now, but have in mind that on my upcoming patch series > >> > > i'm disabling msi (commented out) since it results no interrupts on > >> > > pci-e cards (seems there is a bug in kernel's msi implementation). > >> > > >> > Hm, would be good to get details here. MSI is being used by other > >> > drivers successfully... > >> > >> That's true, but no driver uses the same interrupt handler with and > >> without MSI. Either it's different handlers or the handler checks if > >> MSI is enabled and does something differently. > > > > Yeah, using MSI on your device can mean that you have to make some > > changes (like on Intel graphics you have to disable regular interrupts or > > bad things happen), but you can still share the handler or at least most > > of it in some cases. > > Is there documentation for this somewhere ? Msi documentation > (MSI-HOWTO.txt) doesn't say anything about a different interrupt > handler etc. Matthew just rewrote MSI-HOWTO as part of his rework of the MSI code. It might be more helpful now (see http://kerneltrap.org/mailarchive/linux-kernel/2008/7/1). > > >> Checks is any interrupts are pending are different for MSI. It may be > >> not hard to do (it's probably easier than for real interrupts), but it > >> has to be figured out. Somebody has to do it right. Until MSI is > >> supported by the interrupt handler, it should not be enabled by the > >> driver, or we get a non-functioning driver for AR5006. > > > > Sure, that's fine. I just wanted to make sure that there weren't some > > weird generic MSI problems. > > I was referring to this post... > http://lkml.org/lkml/2008/6/24/150 Yeah, that's a real bug on x86; I don't know how widespread its effects are though. I'll ping Ingo & Thomas again. Jesse -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
