Search Linux Wireless

Re: [RFC 1/4] mt76x0: print BBP version only for debug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>
> > Use dev_dbg to print BBP version.
> >
> > Signed-off-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx>
> > ---
> >  drivers/net/wireless/mediatek/mt76/mt76x0/phy.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
> > index 4fd2c65e196a..ca0a693654a3 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
> > +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
> > @@ -187,7 +187,6 @@ int mt76x0_wait_bbp_ready(struct mt76x0_dev *dev)
> >
> >       do {
> >               val = mt76_rr(dev, MT_BBP(CORE, 0));
> > -             printk("BBP version %08x\n", val);
> >               if (val && ~val)
> >                       break;
> >       } while (--i);
> > @@ -197,6 +196,7 @@ int mt76x0_wait_bbp_ready(struct mt76x0_dev *dev)
> >               return -EIO;
> >       }
> >
> > +     dev_dbg(dev->mt76.dev, "BBP version %08x\n", val);
> >       return 0;
> >  }
>
> I guess we can drop mt76x0_wait_bbp_ready and use mt76x02_wait_for_mac instead
>
> Regards,
> Lorenzo

Please drop the comment, it is a different register. Maybe we can
generalize mt76x02_wait_for_mac instead?

Regards,
Lorenzo

>
> >
> > --
> > 1.9.3
> >



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux