(adding greg) Larry Finger <Larry.Finger@xxxxxxxxxxxx> writes: > On Fri, Sep 21, 2018 at 8:12 AM Stanislaw Gruszka > <sgruszka@xxxxxxxxxx> wrote: > > On Fri, Sep 21, 2018 at 02:03:55PM +0800, yhchuang@xxxxxxxxxxx > wrote: > > I didn't do detailed review, but my general impression is very > very > positive. New driver looks great! > > Just 2 generic remarks: > - please add MAINTAINERS file entry > - please post a patch or request to remove staging/rtlwifi driver > since this one is replace for it (8822BE PCI-ID is the same) > > Keep in mind that the new driver is going into wireless, and the old > one is in staging. With separate maintainers, doing this in a single > series of commits is very difficult to coordinate. One way would be to > submit the deletion patch to GregKH (or whomever is maintaining > staging) with a note that it should be held until rtwlan appears in > mainline, and then submitted directly to mainline as well as staging. > I'm sure there will be a solution, just that it cannot be handled as a > normal patch set. My guess is that Greg would be ok that we remove the staging driver via wireless-drivers-next at the same time as we apply the new driver to drivers/net/wireless. But let's coordinate that with Greg once this new driver is ready for commit, we are not quite there yet. -- Kalle Valo
